Require nanobind 2.x when building for Python 3.9 - #351
Merged
godlygeek merged 1 commit intoAug 26, 2026
Conversation
Nanobind 3.x dropped support for Python 3.9, but its packaging metadata does not reflect that change. Work around this by declaring the restriction ourselves. Note that as things stand today, anyone who wants to build any previously published sdist for Python 3.9 will need to supply the `--build-constraint` argument to `pip install` or the `--build-constraints` argument to `uv pip install` and provide a file containing a `nanobind < 3` constraint, essentially providing the metadata on each `pip install` call that isn't currently reflected in the `nanobind` package's published metadata. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
- Coverage 77.57% 77.56% -0.01%
==========================================
Files 57 57
Lines 6612 6611 -1
Branches 630 630
==========================================
- Hits 5129 5128 -1
Misses 1483 1483
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sarahmonod
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nanobind 3.x dropped support for Python 3.9, but its packaging metadata does not reflect that change. Work around this by declaring the restriction ourselves.
Note that as things stand today, anyone who wants to build any previously published sdist for Python 3.9 will need to supply the
--build-constraintargument topip installor the--build-constraintsargument touv pip installand provide a file containing ananobind < 3constraint, essentially providing the metadata on eachpip installcall that isn't currently reflected in thenanobindpackage's published metadata.Relates-to wjakob/nanobind#1424