kraken: raise ExtensionNotFound when restarting uninstalled extension - #4185
Open
Safe-bet wants to merge 1 commit into
Open
kraken: raise ExtensionNotFound when restarting uninstalled extension#4185Safe-bet wants to merge 1 commit into
Safe-bet wants to merge 1 commit into
Conversation
Member
|
Hi @Safe-bet, thanks for the work, the team will review it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4160
POST /kraken/v2.0/extension/{identifier}/restartfor an extension identifier that was never installed previously returned HTTP 400 (Extension {identifier} have no running versions) instead of HTTP 404 (Extension {identifier} not found).This PR updates
Extension.from_running(identifier)to raiseExtensionNotFound(HTTP 404) when theinstalledlist is empty, while preservingExtensionNotRunning(HTTP 400) when the extension is installed but disabled.