Skip to content

[backport/1.4] ardupilot-manager: return empty list on non-Linux flight controllers - #4199

Merged
patrickelectric merged 1 commit into
bluerobotics:1.4-devfrom
joaoantoniocardoso:backports/1.4/ardupilot-serials-non-linux-fc
Aug 20, 2026
Merged

[backport/1.4] ardupilot-manager: return empty list on non-Linux flight controllers#4199
patrickelectric merged 1 commit into
bluerobotics:1.4-devfrom
joaoantoniocardoso:backports/1.4/ardupilot-serials-non-linux-fc

Conversation

@joaoantoniocardoso

@joaoantoniocardoso joaoantoniocardoso commented Aug 20, 2026

Copy link
Copy Markdown
Member

This is a backport of #4184 into 1.4.

@joaoantoniocardoso
joaoantoniocardoso requested a review from a team August 20, 2026 01:48
@joaoantoniocardoso
joaoantoniocardoso marked this pull request as ready for review August 20, 2026 01:50
@github-actions

Copy link
Copy Markdown

Automated PR Review

0. Summary

  • Verdict: LGTM :shipit:

Straight backport of #4184 into 1.4-dev. In core/services/ardupilot_manager/autopilot_manager.py:304-307, replaces an assert isinstance(self._current_board, LinuxFlightController) in AutopilotManager.get_serials() with an early return [] for non-Linux boards, so a missing serials configuration on non-Linux flight controllers no longer raises AssertionError. Callers (get_serial_cmdline in particular) degrade cleanly to an empty argument list.

No further comments, nice job 👍

Generated by PR Review Bot. This is advisory, a human reviewer must still approve.

@patrickelectric
patrickelectric merged commit ee8a788 into bluerobotics:1.4-dev Aug 20, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants