fix: -t draws the (others) row out of size order - #615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
-t, the aggregated(others)row is appended after the list is sorted, so when its total is larger than the rows above it the tree comes out in the wrong order and the "biggest" highlight lands on the wrong row.Four files of 40Ki, 30Ki, 20Ki and 10Ki, shown with
-t -n 2:The after order matches how dust draws a normal listing, where the largest sits nearest the total. The list is re-sorted once the
(others)node has been pushed, inside the branch that creates it, so output without an(others)row is unchanged.Test added in
src/filter_type.rs; removing the sort fails it.cargo testpasses, 33 plus 8 plus 31 plus 4.cargo fmt --checkclean; the 4 clippy warnings intests/are pre-existing and identical on an unmodified checkout.AI disclosure: written with Claude Code. I ran the binary before and after and checked the mutation myself.