feat(codegen): scaffold feature mutations with the correct apiClient pattern#305
Merged
Conversation
…pattern
new:feature generated queries (with the correct 'const { data } = await apiClient.GET'
pattern in a doc comment) but NO mutations file — so a resource's create/update code
was written from scratch, and the common mistake was guarding response.error, which
this stack forbids (errors throw via the client middleware, so response.error is typed
undefined → dead no-unnecessary-condition lint errors, 4-6 per feature).
Scaffold Feature.mutations.ts with a compiling useCreate stub plus the correct pattern
documented inline (destructure { data }, never touch response.error), mirroring the
queries stub. Also add the same 'errors throw — don't check response.error' note to the
queries stub comment. The model now fills domain fields on right-shaped code instead of
inventing client plumbing.
Verified: new:feature Widget → generated mutations + queries lint-clean and typecheck-clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
new:featurescaffoldsFeature.queries.ts(with the correctconst { data } = await apiClient.GET(...)pattern in a doc comment) but no mutations file. So a resource's create/update/delete code gets written from scratch, and the recurring mistake is guardingresponse.error— which this stack forbids: errors throw via the client middleware, soresponse.erroris typedundefinedand every guard is a dead@typescript-eslint/no-unnecessary-conditionerror (observed 4–6 per feature in an autonomous build, ~15 min of thrash).What
Feature.mutations.ts: a compilinguseCreate<Feature>stub + the correct pattern documented inline (destructure{ data }, never touchresponse.error), mirroring the queries stub.response.error" note to the queries stub comment (queries.ts hit the same lint error).The model now fills domain fields on right-shaped code instead of inventing client plumbing.
Verified
new:feature Widget→ generatedWidget.mutations.ts+Widget.queries.tsare lint-clean and typecheck-clean.