Repository navigation
ci: pin golangci-lint to v2.15.0 and split Squeeze - #158
Merged
Merged
Conversation
The lint job installed golangci-lint 'latest', which resolved to v2.15.0 and flagged the cognitive complexity of tensor.Squeeze (24 > 20), turning lint red on every PR without a code change. The version is now pinned, so a new linter release no longer changes CI on its own. Squeeze keeps its behaviour; the two shape computations move into squeezeAllOnes and squeezeAxes. A table test covers the raw Squeeze directly (all ones, negative and duplicate axes, the size check).
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The lint job installs golangci-lint
latest. That now resolves to v2.15.0, which flags the cognitive complexity oftensor.Squeeze(24 > 20). As a result, lint fails on every PR, #157 included, without any change to the code.golangci-lint-actiontoversion: v2.15.0, so a new linter release no longer changes CI by itself. Bumping it becomes a deliberate change.Squeeze: the two shape computations move intosqueezeAllOnesandsqueezeAxes, and the behaviour stays the same. A new table test covers the rawSqueezedirectly: all size-1 dims, negative and duplicate axes, the size check and the nil input. It passes on the old code too.Locally, golangci-lint v2.15.0 reports 0 issues over all packages, and
internal/tensorandinternal/onnx/...tests pass.