Fix crash after "Failed to recognize type" - #27
Open
slburson wants to merge 2 commits into
Open
Conversation
added 2 commits
May 20, 2026 15:41
The three 'parse-type' methods I deleted cannot be called; 'kind' is a type kind, i.e. ':record', not a declaration kind.
slburson
commented
Jul 1, 2026
| (:function-prototype-pointer (let ((overriden (%overtype :function-prototype-pointer))) | ||
| (if (eq overriden :function-prototype-pointer) | ||
| (%overtype :void) | ||
| (%overtype :pointer) |
Author
There was a problem hiding this comment.
Ignore this; I based this PR on the wrong commit.
slburson
commented
Jul 1, 2026
Comment on lines
-851
to
-864
| (defmethod parse-type (category (kind (eql :struct)) type) | ||
| (declare (ignore category kind)) | ||
| (parse-declaration-by-kind (%resect:type-declaration type) type)) | ||
|
|
||
|
|
||
| (defmethod parse-type (category (kind (eql :union)) type) | ||
| (declare (ignore category kind)) | ||
| (parse-declaration-by-kind (%resect:type-declaration type) type)) | ||
|
|
||
|
|
||
| (defmethod parse-type (category (kind (eql :class)) type) | ||
| (declare (ignore category kind)) | ||
| (parse-declaration-by-kind (%resect:type-declaration type) type)) | ||
|
|
Author
There was a problem hiding this comment.
These methods can't be called — kind here is a type-kind, not a declaration kind, so it can't have these values, only :record — and I found their presence very confusing at first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At one point, as I was adjusting the inclusions and exclusions for Claw-Torch, I got four instances of this message:
followed by a no-such-method error on
claw.spec::foreign-entity-id. I don't know why I got the "failed to recognize type" message, but I wanted to get output anyway, so I added a quick hack to allow the process to proceed.