Repository navigation
fix: allow explicit thread render overrides - #247
Open
Aryan R. Ganjoo (AryanRG) wants to merge 1 commit into
Open
Aryan R. Ganjoo (AryanRG) wants to merge 1 commit into
Aryan R. Ganjoo (AryanRG) wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
LLMClassifierreceives a trace and evaluation-timethreadorthread_count, its separate keyword expansions raiseTypeErrorbefore rendering. Merge the computed variables and explicit arguments into one mapping in both sync and async request assembly, so explicit values take precedence and other computed values remain available.Add three regressions covering sync and async thread/count overrides and an independent count-only collision. The combined cases also verify that the computed full thread retains its system message.
Validation on CPython 3.14.4, macOS arm64, with lock-pinned dependencies and networking denied:
test_llm.py: 18 passed, four provider integrations intentionally unrun, one missing-credentials failure intest_factuality.test_oai.pytests remained in scope.git diff --checkpassed.The complete
dev/scipy/litellmclosure was installed from verified lock-pinned wheels. The documentation extra remains incomplete because its pinneddocstring-parser==0.11andwatchdog==6.0.0have no compatible locked wheels. Real-provider integration, other Python versions, TypeScript tests, aggregate pre-commit, and codespell were not run. No provider credentials were supplied.