Repository navigation
fix: isolate embedding cache by default client - #257
Open
Jacqueline122 wants to merge 1 commit into
Open
Jacqueline122 wants to merge 1 commit into
Jacqueline122 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #256.
After
init(client=...)switches the default client, Python'sEmbeddingSimilaritycan return a score computed from the previous client's cached vectors without contacting the new provider. In the offline reproduction, provider B should yield 0.0 but returns the cached 1.0.Key embeddings by the effective explicit or context-default client. An internal identity token on
LLMClientprevents cache collisions if a replaced client's integer object ID is reused. Repeated evaluations with the same client still reuse cached embeddings.Regression tests cover sync/async client switching, cache reuse across scorer instances, explicit-client precedence, and isolation between asyncio tasks. This follows the model/prefix isolation work in #213; the remaining case is a default client configured through
init().Validation
To run the 40 targeted tests from the repository root:
AI assistance
OpenAI Codex assisted with investigation, reproduction, implementation, and regression tests.