Repository navigation
Automatically activate Codex tracing hooks - #211
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3f136c6e82
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Stephen Belanger (Qard)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Andrew Kent (realark)
October 23, 2026 13:58
Abhijeet Prasad (AbhiPrasad)
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex skips untrusted plugin hooks before Braintrust receives their events. This PR makes
bt trace enable codexandbt trace update codexenforce the installed-and-trusted state automatically. If the plugin is missing, setup installs it. If its packaged hook definitions are untrusted or modified, setup trusts the current Codex-reported hashes and verifies the result. Setup fails if it cannot establish that state.Codex's
/hooksUI usesconfig/batchWriteto upserthooks.stateentries containing the exact key andtrusted_hashsupplied byhooks/list. Setup verifies the complete installed hook file against thisbtbuild, including Windows commands, before writing trust. Unrelated hook trust and configuration are preserved. Doctor no longer duplicates plugin installation and trust status.bt trace run codexuses the same packaged definitions and invocation-scoped trust without changing persistent Codex configuration. Managed runs load all 12 packaged hook overrides, obtain their exact keys and hashes from Codex, and pass trust as a CLI-only config override. The invocation-wide--dangerously-bypass-hook-trustflag is not used.SDK-583
Validation on macOS:
bt-daemonpipeline integration tests passed, includingmanaged_run_flushes_and_preserves_agent_exit_status, which failed in CI because its fake Codex executable did not implement the new app-server trust-preparation protocol. The fixture now responds to initialization and hook-list requests.cargo check --manifest-path bt-daemon/Cargo.toml --all-features --locked, Clippy with all targets/features and warnings denied,cargo fmt -- --check, andgit diff --checkpassed.