Repository navigation
fix(pi): honor the host configuration directory for global settings - #232
Wolfie (wolfiesch) wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
CI passed on my fork at this PR's head ( |
|
Closing this. |
The Pi extension reads project settings from the running host's config directory (
piConfig.configDir), but global settings always come from~/.pi/agent/braintrust.json. A Pi-compatible host with its own config directory, or one that relocates its agent directory withPI_CODING_AGENT_DIR(for example, named profiles), has no global settings file of its own.loadConfignow layers:~/.pi/agent/braintrust.json, whichbt trace enable piwrites, so existing setups keep workingbraintrust.jsonin the host's agent directory (PI_CODING_AGENT_DIR, or~/<configDir>/agent) when that path differs from~/.pi/agentUpstream Pi without
PI_CODING_AGENT_DIRreads exactly the files it read before. The README documents the order.Validation (
src/plugins/pi/content):vp checkvitest run; new cases inconfig.test.tscoverPI_CODING_AGENT_DIR, a host config directory overriding~/.pi/agent, and a host still honoring the filebt trace enable piwrites.