Repository navigation
fix(pi): report the running host package instead of an installed peer - #234
Open
Wolfie (wolfiesch) wants to merge 3 commits into
Open
Wolfie (wolfiesch) wants to merge 3 commits into
Wolfie (wolfiesch) wants to merge 3 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Author
|
CI passed on my fork at this PR's head ( |
Keep Oh My Pi sessions on the extension's existing .pi settings path and the Pi session-root label. Only the reported host name and version change. Drop the explicit-manifest rule so a stale PI_PACKAGE_DIR cannot select an unrelated parent package.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Pi extension resolves Pi's package metadata from the running CLI, but accepts a host only when its manifest name is one of the two upstream Pi packages or it declares
piConfig. Oh My Pi (@oh-my-pi/pi-coding-agent) matches neither, so the lookup falls through to the@earendil-works/pi-coding-agentcopy installed as the extension's peer dependency, and traces report that peer's version aspi_version.Changes:
pi-package.tsadds@oh-my-pi/pi-coding-agentto the known package names and returns the matched package name. The config directory is unchanged, so existing.pi/braintrust.jsonsettings, including project opt-outs, still apply.payload.host_name, and the translator records it asmetadata.host_name. The transportsourcestayspi, and the session root keeps thePilabel.protocol.mdand the Pi README describe the field.Limitation: Oh My Pi's standalone binary does not ship a
package.json, so the extension cannot identify it from the filesystem. Those sessions keep reporting the peer dependency's version, as they do today.Validation:
src/plugins/pi/content:vp check,vitest runbt-daemon(Rust 1.99.1):cargo fmt --check,cargo clippy --all-targets -- -D warnings,cargo test --all-featuresloadPiPackageMetadataagainst an Oh My Pi 18.12.6 source checkout's CLI entry with the upstream peer installed. It returns@oh-my-pi/pi-coding-agent,18.12.6,.pi.