Repository navigation
fix(cursor): parent subagent spans to the spawning turn - #238
Open
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit into
Open
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit into
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit into
Conversation
> 🤖 **This text was AI-generated.**
Cursor subagent spans were children of the spawning tool, and the task was stored as a raw string. The instrumentation spec's turn tree puts the subagent on the same trace as the user turn that spawned it, with `metadata.turn_span_id` set to that turn. A raw string also broke stop correlation: a stop that omitted `subagent_id` compared the task to `input` as a string, so it could not find the open child.
Subagent spans now share the session root and hang directly off that user turn. The spawning tool call id stays in metadata. The task is a user message, and a stop without an id matches that same message.
```text
session
└── turn
├── tool Task
└── task Cursor subagent
input: [{role: "user", content: "<task>"}]
```
Stops that do not match an open start still become a terminal observation on the turn. Inner model and tool work is not attached under the subagent, because Cursor does not provide a verified link for that activity.
Co-authored-by: Cursor <cursoragent@cursor.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cursor subagent spans were children of the spawning tool, and the task was stored as a raw string. The instrumentation spec's turn tree puts the subagent on the same trace as the user turn that spawned it, with
metadata.turn_span_idset to that turn. A raw string also broke stop correlation: a stop that omittedsubagent_idcompared the task toinputas a string, so it could not find the open child.Subagent spans now share the session root and hang directly off that user turn. The spawning tool call id stays in metadata. The task is a user message, and a stop without an id matches that same message.
Stops that do not match an open start still become a terminal observation on the turn. Inner model and tool work is not attached under the subagent, because Cursor does not provide a verified link for that activity.