Repository navigation
Test out paths-ignore github setting - #1071
Closed
Caitlin Pinn (cpinn) wants to merge 2 commits into
Closed
Caitlin Pinn (cpinn) wants to merge 2 commits into
Caitlin Pinn (cpinn) wants to merge 2 commits into
Conversation
Caitlin Pinn (cpinn)
force-pushed
the
caitlin/build-changes
branch
from
November 11, 2025 06:02
29383fa to
22f6576
Compare
Caitlin Pinn (cpinn)
changed the title
Caitlin Pinn (cpinn)
requested review from
Olmo Maldonado (ibolmo) and
Ken Jiang (knjiang)
November 11, 2025 06:09
| pull_request: | ||
| paths-ignore: | ||
| - "py/**" | ||
| - "integrations/langchain-py/**" |
Contributor
There was a problem hiding this comment.
could try `integrations/*-py/**
| - "js/**" | ||
| - "integrations/langchain-js/**" | ||
| - "integrations/vercel-ai-sdk/**" | ||
| - "integrations/openai-agents-js/**" |
Contributor
There was a problem hiding this comment.
similarly - "integrations/*-js/**" and you can add vercel-ai-sdk separately for now.
Contributor
Author
|
I did also find out we have been using path in the main repo just a little bit and it looks like it is working as expected there: https://github.com/braintrustdata/braintrust/pull/6875 |
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If this PR is still relevant, please leave a comment, push an update, or remove the stale label. Thank you for your contributions! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
It was bugging me all week that when I was making just js sdk changes all the python builds would build.
Changes
Add and test out the paths ignore github setting.
There is no great way I have thought of to test workflow changes like this locally since once you make the change to the workflow yaml those workflow jobs will always run.
I could put the filter changes directly into the js.yaml and py.yaml builds but I figured it might be nice to try out the filter settings in a separate job, watch when the two trigger jobs run during some PRs and then add the changes to the real jy.yaml and py.yaml jobs.