Repository navigation
fix(harbor): respect trial reward validity - #1008
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intoOct 26, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi/harbor-reward-validity-16730ec8
branch
October 26, 2026 13:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harbor 0.25.0 marks a trial's rewards invalid when a recorded failure makes them untrustworthy. The Braintrust plugin previously converted those rewards into normal scores:
The plugin now checks
TrialResult.reward_validbefore converting rewards. Invalid rewards produce no scores or derived metrics:Span metadata also records
reward_validandfailure_causewhen Harbor exposes them. Valid rewards still convert normally, including after exceptions whose policies preserve reward validity. Feature detection keeps the existing behavior on Harbor versions before 0.25.0, including the supported 0.16.0 pin.Fixes SDK-633.
Closes #1007.