Repository navigation
fix(openai): materialize decisions instructions and tool outputs - #1009
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intoOct 26, 2026
Conversation
> 🤖 **This text was AI-generated.**
Decisions logged generator-valued question instructions and tool outputs
as generator representations instead of their input parts.
```text
before: instructions/output -> "<generator object ...>"
after: instructions/output -> [{"type": "input_text", "text": "..."}]
```
Materialize these fields once so tracing and OpenAI receive the same
values without replacing fields on the caller's dictionaries. Extend the
existing sync/async iterable-input coverage and refresh its cassettes.
Fixes #1006
Refs: https://linear.app/braintrustdata/issue/SDK-632
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi/sdk-632-openai-decisions-materialize-generator-valued-instructions
branch
October 26, 2026 15:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decisions logged generator-valued question instructions and tool outputs
as generator representations instead of their input parts.
Materialize these fields once so tracing and OpenAI receive the same
values without replacing fields on the caller's dictionaries. Extend the
existing sync/async iterable-input coverage and refresh its cassettes.
Fixes #1006
Refs: SDK-632