Repository navigation
fix(cohere): capture rerank relevant_spans - #1010
Merged
Abhijeet Prasad (AbhiPrasad) merged 2 commits intoOct 26, 2026
Merged
Conversation
> 🤖 **This text was AI-generated.**
Cohere v2 rerank dropped the relevant_spans request option from trace
metadata and discarded the matching passages returned by v5 models:
```text
before: output[] = {index, relevance_score}
```
Capture the option in the metadata allowlist and include each returned
passage's character offsets and relevance score:
```text
after: metadata.relevant_spans = {mode, threshold?, max_spans?}
output[] = {index, relevance_score, relevant_spans?: [{start, end, score}]}
```
Omit relevant_spans when absent from a result. Add a recorded v5 example
covering both cases and skip it on SDK versions without the request option.
Fixes #1004
Refs: https://linear.app/braintrustdata/issue/SDK-630
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi/cohere-rerank-spans-08e6d9d0
branch
October 26, 2026 15:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cohere v2 rerank dropped the relevant_spans request option from trace
metadata and discarded the matching passages returned by v5 models:
Capture the option in the metadata allowlist and include each returned
passage's character offsets and relevance score:
Omit relevant_spans when absent from a result. Add a recorded v5 example
covering both cases and skip it on SDK versions without the request option.
Fixes #1004
Linear: SDK-630