Repository navigation
fix(workflow-eval): retry failed per-case submissions on poll - #995
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intoOct 26, 2026
Merged
Conversation
A WorkflowTask or WorkflowScorer submit that raised left its case claimed with no submission record, so the run stayed waiting forever. Record the failure like batch submissions do, so the next poll() resubmits it. This matches the JS SDK. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Abhijeet Prasad (AbhiPrasad)
approved these changes
Oct 26, 2026
Abhijeet Prasad (AbhiPrasad)
deleted the
paul/workflow-eval-retry-failed-submit
branch
October 26, 2026 12:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SDK-617.
If
submitraised for a per-caseWorkflowTaskorWorkflowScorer, the case stayed claimed and no submission record was written.Every later
poll()returnedwaiting, andsubmitnever ran again, so the run could never complete.This change records the failure the same way the batch path already does: a
failedsubmission record withattempts. The existing retry branch inpoll()now resubmits non-batch submissions too, with the samesubmission_id. This matches the JS SDK, which documents: "Whensubmitthrows, its items stay with that submission and it counts as pending. The nextpoll({ runId })retries it with the samesubmissionId."pendingchange: a failed per-case submission now counts inpending.poll/pending.webhookuntil it's retried. Failed batch reservations already count this way, and so does JS. That's why the assertion intest_submission_error_waits_for_independent_submissionschanges from 2 to 3._batch_key. It's a single-key lease, so the Redis Cluster slot grouping that_batch_keyexists for doesn't matter here.get_external_idfailure after a successfulsubmitis still unhandled. JS has the same gap.Test:
test_failed_submit_is_retried_on_pollfails onmainand passes with this change.