Repository navigation
Separate ingestion encoding, batching, and upload planning - #119
Merged
Stephen Belanger (Qard) merged 1 commit intoOct 28, 2026
Merged
Conversation
Stephen Belanger (Qard)
merged commit Oct 28, 2026
9b05400
into
refactor/retry-executor
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both ingestion upload paths previously grouped rows by row bytes alone, omitting the JSON envelope and separators. They also made separate decisions about oversized payloads and HTTP 413 responses.
Introduce a generic ordered batcher, a shared logs3 encoder, and a pure upload planner. Batch limits now include the complete request body; exact-limit bodies fit. Oversized rows remain explicit singleton work for overflow or a terminal size error. A rejected direct request is replanned as overflow or ordered splits, never retried unchanged. Both existing upload paths use these components; protocol and retry consolidation follows in the next layer.
Validation: 230 unit/integration tests and 7 doctests passed (existing ignores unchanged), strict clippy, rustdoc, formatting, and diff checks passed. Added coverage for envelope/separator/UTF-8 sizes, overflow-safe weight arithmetic, oversized rows, metadata, ordered 413 splits, and 413-to-overflow fallback.
Stacked above #118. Planning documents remain outside version control.