Repository navigation
Submit experiment feedback and span patches eagerly - #132
Closed
Stephen Belanger (Qard) wants to merge 1 commit into
Closed
Stephen Belanger (Qard) wants to merge 1 commit into
Stephen Belanger (Qard) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experiment feedback and span updates previously waited for polling and registration before entering the delivery queue. Make log_feedback and update_span submit their merge writes immediately and return Completion tokens that resolve after full batch delivery. Accepted patches remain covered by flush/shutdown even if their tokens are never observed.
Events and patches share one private admission helper: reserve response capacity first, then admit the write with either a cached destination or deferred registration. Rejection leaves no registration or write obligation behind. IDs and payloads are owned when the public call returns; patches remain independent of the finished state of live span handles.
Stacked on #131. Experiment reads/builders/summaries, traced callbacks, and client span updates remain subsequent layers.
Validation: 330 unit/integration tests and 9 doctests passed, with existing ignored tests unchanged. Strict all-target/all-feature Clippy, rustdoc, formatting, and diff checks passed. Consumer regressions cover unobserved owned patches through shutdown before task polling, exact merge fields, a failed registration batch followed by successful fresh retry, patches to a finished span, both admission limits without extra work, and timeout while registration is pending.