Repository navigation
Submit client span updates eagerly and observe delivery - #134
Closed
Stephen Belanger (Qard) wants to merge 1 commit into
Closed
Stephen Belanger (Qard) wants to merge 1 commit into
Stephen Belanger (Qard) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client span updates previously exposed only queue admission: the explicit-credential method returned before delivery, while the login-dependent async method queued nothing until polled and login finished. Make both methods submit immediately and return Completion tokens covering validation, pending login, preparation, and full batch delivery.
Stacked on #133. Traced callbacks and the standalone direct API completion facade remain subsequent layers.
Validation: 343 unit/integration tests and 9 doctests passed, with existing ignored tests unchanged. Strict all-target/all-feature Clippy, rustdoc, formatting, and diff checks passed. New consumer regressions cover plain-thread unobserved updates after owner drop, gated pending login through shutdown with organization-selected routing, terminal batch failure and fresh retry, validation and both admission limits, login timeout, and stopped-runtime cleanup when pending scope resolution owns the client. Existing credential, span-origin, parent, finished-span, experiment and pagination tests passed.