Repository navigation
Separate reusable evaluation definitions from run options - #141
Closed
Stephen Belanger (Qard) wants to merge 1 commit into
Closed
Stephen Belanger (Qard) wants to merge 1 commit into
Stephen Belanger (Qard) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evaluation options previously owned the task and scorers, so running another source required rebuilding or manually wrapping the callbacks.
EvalDefinitionnow owns a validated, shared definition; eachEvalOptssupplies that definition alongside its own source and run options. Cloning a definition shares callbacks without requiring cloneable inputs or outputs.Scorer names are captured once and rejected when empty or duplicated. The recorded evaluator uses the shared definition, while each invocation retains independent hooks, results and recording spans. Examples and documentation show constructing the definition separately from run options.
This continues stage 8 of the release refactor, stacked on #140. Eager run scheduling, managed blocking callbacks and recorder extraction remain subsequent layers.
Validation: