Repository navigation
Submit local and recorded evaluation runs eagerly - #143
Closed
Stephen Belanger (Qard) wants to merge 1 commit into
Closed
Stephen Belanger (Qard) wants to merge 1 commit into
Stephen Belanger (Qard) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Evaluation runs now submit immediately and return the same completion token for synchronous and asynchronous callers.
eval::run(EvalRequest::local(options))needs no client, credentials or serialization; it uses the requested runtime or an owned runtime.EvalRequest::recorded(options, client)inherits the client's runtime and lifecycle. Conflicting recorded runtime overrides and invalid options are rejected synchronously.Recorded admission reserves both a response slot and a bounded operation write lease before returning. The recorder builds spans within that admitted operation, so shutdown can close public admission while accepted callbacks and recording finish their writes. Completion, panic, runtime loss and timeout release the lease; escaped spans cannot keep writing after the run. Dropping an observer leaves accepted work running.
The client-bound
Evaluatordelegates to this entry point. RemovedSyncEvaluatorand its second runtime; the synchronous example waits for the same completion token on a plain thread. This continues stage 8, stacked on #142. Managed blocking callback adapters, experiment-backed recording, dataset-source integration and remaining CLI adapters are subsequent layers.Validation: