Repository navigation
Make CLI construction eager and consolidate the evaluation API - #151
Closed
Stephen Belanger (Qard) wants to merge 1 commit into
Closed
Stephen Belanger (Qard) wants to merge 1 commit into
Stephen Belanger (Qard) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI construction previously ran only when polled, ignored malformed filters, and could switch output modes after an SSE connection failure.
BtEvalRunner::from_envandwith_clientnow return eager completions with typedBtInitErrorfailures. Configuration is captured at issuance; malformed filter JSON/schema/regex rejects before setup. Explicit SSE failures are returned without falling back to another transport or terminal output.List mode creates no client, runtime or socket. Local mode creates no client/login. Socket setup runs on the selected binding's managed blocking pool, and recording-mode client initialization begins only after it succeeds. A private client-builder composition hook reuses existing validation, initialization and the same response reservation/runtime. Supplied-client constructors participate in its admission and shutdown; discarded observers do not cancel accepted setup.
Removed the transitional client-bound
Evaluatorfacade and movedEvalOptsinto its own options module. Examples and existing callable/source/concurrency/error tests now useEvalDefinition,EvalRequestandrun. CLI configuration parsing is isolated from execution, and filter tests no longer mutate the test process's environment.Stacked on #150 (
refactor/eager-cli-evaluations), continuing the original release-preparation stage. Dependency/MSRV reconciliation, packaging/docs and legacy uploader consumer migration remain subsequent work. Planning notes remain local.Validation: