Skip to content

Double default Brainstore memory per CPU - #113

Open
Kevin Green (KevinGreen) wants to merge 1 commit into
mainfrom
kevin/brainstore-memory-defaults
Open

Kevin Green (KevinGreen) wants to merge 1 commit into
mainfrom
kevin/brainstore-memory-defaults

Conversation

@KevinGreen

Copy link
Copy Markdown
Contributor

Increase default Brainstore memory from 2 GiB to 4 GiB per CPU, matching the updated self-hosting sizing guidance. Readers and fast readers now request and limit 64 GiB with 16 CPUs; writers and automation writers use 128 GiB with 32 CPUs.

Update the GKE Standard, Autopilot, and Autopilot CEL examples, the README sizing example, and the automation-writer fallback defaults. CPU counts, replicas, storage settings, and chart/image versions are unchanged. Clusters using these defaults need enough node memory to schedule the larger pods.

Configuration behavior

Input Behavior
AWS, GCP, Azure All four pools render the increased default requests and limits.
Explicit resource overrides Continue to take precedence; existing CI fixtures retain their custom sizing.
Enabled/disabled pools Replica counts and enablement are unchanged, including the disabled-by-default automation writer.
Image tags: releases, SHAs, prereleases, custom tags No changes to image handling or validation.
Upgrades with reused values Explicitly retained resource values remain retained; the automation-writer fallback uses the increased memory when fields are absent.
Null/missing values, zero replicas, partial maps Existing rendering and validation logic is unchanged; only the default memory constants change.

Validation

  • Full ./test.sh: 419 Helm unit tests across 35 suites and 33 Python tests passed.
  • AWS, GCP, Azure, and minimal CI profiles render successfully; strict Helm lint passes.
  • Separately rendered all four pools with resource overrides removed on AWS, GCP, and Azure and verified CPU and memory requests/limits.
  • Rendered all three updated deployment examples and the API autoscaling overlay with its required API version.
  • Verified the default/example values only change Brainstore memory, and each configured pool uses 4 GiB per CPU.
  • git diff --check passes. No live cluster deployment or scheduling test performed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T20:46:31.127972Z 7e73712 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant