Repository navigation
feat: tokens, icon set and no inline styles (UX-10, part B) - #215
Merged
Merged
Conversation
- all static inline styles replaced by classes (shared section-head/section-title/spinner/btn-danger, scoped classes); :style only for data-driven geometry - AppIcon with 13 outline icons replaces emojis; collection icons stored by name (older emojis still shown) - hard-coded hex colors, Tailwind palette classes, border radii and z-index literals replaced by tokens (radar/bars, confetti, level colors, settings danger zone, theme.css) - guard tests scan sources for inline styles, emojis, hex colors, palette classes, radii, z-index - fixes: header had no background (bg-app-bg/80 is not generated for CSS variables), light-only table highlight, broken "drill not found" markup, text-gray-600 in dark mode - tests (452) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes UX-10 (part A: dialogs, focus, contrast, axe - #214).
style="..."attributes replaced by classes (sharedsection-head,section-title,spinner,btn-danger,row-*, ...; scoped classes elsewhere).:styleremains only for data-driven geometry (bar widths, marker positions, confetti, a measured height)AppIconwith 13 outline icons (24 px grid,currentColor, decorative unless labeled) replaces the emojis (balls, clubs, tools, timer, award, trend, chart ...). Collections now store an icon name; collections from earlier versions that hold an emoji are still shown (CollectionIcon)text-gray-600,bg-zinc-50,bg-red-50,border-t-blue-500, ...), border radii (999px,14px, ...) and thez-index: 9999toast now use--primary,--danger-*,--radius-*,--z-*etc. The settings danger zone and switch rows follow the theme in dark modetests/a11y/system.test.ts) scan the sources and name file and line: no static inline styles,:stylewithout color/spacing/typography, no emoji, no hex colors in components (one documented exception: the native status bar), no palette classes, radii > 6 px only via tokens, no literal z-indexBugs found by the guards / while converting
bg-app-bg/80is not generated for CSS-variable colors, so content scrolled under a transparent header. Nowcolor-mixfrom--bgbg-emerald-50)<output>followed by loose content); now a proper status card (tested)text-gray-600on dark surfaces in three loading/empty states (low contrast); spinner colors ignored the themeNumbers
Start JS 148.0 KB (+0.8 KB for the icon set), CSS 22.0 KB, tests 437 -> 452, lint 0 errors.
Test plan
npm test,npm run lint,npm run typecheck,npm run build(local)🤖 Generated with Claude Code