Repository navigation
Require fsspec 2023.3.0 or later - #115
Open
simonvanlierde wants to merge 1 commit into
Open
simonvanlierde wants to merge 1 commit into
simonvanlierde wants to merge 1 commit into
Conversation
Older releases lack DirFileSystem, can't write zip files, or ignore the zip compression.
simonvanlierde
marked this pull request as ready for review
October 28, 2026 13:08
3 of 25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
fsspechas no lower bound, but bw_processing needs a fairly recent one. A resolver that picks the lowest allowed version (uv pip install --resolution lowest-direct) installs fsspec 0.5.1, andimport bw_processingfails.fsspec.implementations.dirfs, whichio_helpersimports, first shipped in fsspec 2022.2.0.ZipFileSystemcan't write before 2022.8.2, and up to 2023.1.0 it ignores thecompression=thatgeneric_zipfile_filesystempasses, sotest_zipfile_default_compressionfails.fsspec>=2023.3.0, the first release where the whole suite passes. There is no 2023.2.0.Tests: 273 pass and 1 skips on Python 3.12, with every dependency at the lowest version its bound allows, in a clean container. I found this with a nightly check of the Brightway stack's declared floors: https://github.com/simonvanlierde/brightway-benchmarks/blob/main/scripts/compat.sh.
Best,
Simon