Skip to content

Require fsspec 2023.3.0 or later - #115

Open
simonvanlierde wants to merge 1 commit into
brightway-lca:mainfrom
simonvanlierde:chore/dependency-floors
Open

simonvanlierde wants to merge 1 commit into
brightway-lca:mainfrom
simonvanlierde:chore/dependency-floors

Conversation

@simonvanlierde

Copy link
Copy Markdown

Hi,

fsspec has no lower bound, but bw_processing needs a fairly recent one. A resolver that picks the lowest allowed version (uv pip install --resolution lowest-direct) installs fsspec 0.5.1, and import bw_processing fails.

  • fsspec.implementations.dirfs, which io_helpers imports, first shipped in fsspec 2022.2.0.
  • ZipFileSystem can't write before 2022.8.2, and up to 2023.1.0 it ignores the compression= that generic_zipfile_filesystem passes, so test_zipfile_default_compression fails.
  • So this sets fsspec>=2023.3.0, the first release where the whole suite passes. There is no 2023.2.0.

Tests: 273 pass and 1 skips on Python 3.12, with every dependency at the lowest version its bound allows, in a clean container. I found this with a nightly check of the Brightway stack's declared floors: https://github.com/simonvanlierde/brightway-benchmarks/blob/main/scripts/compat.sh.

Best,
Simon

Older releases lack DirFileSystem, can't write zip files, or ignore the zip compression.
@simonvanlierde
simonvanlierde marked this pull request as ready for review October 28, 2026 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant