Skip to content

fix: avoid cctype UB, dedupe msvc-runtime errors, use std::any_of #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Wael-MA wants to merge 3 commits into from
Closed

fix: avoid cctype UB, dedupe msvc-runtime errors, use std::any_of #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9597199
fix: avoid cctype UB, dedupe msvc-runtime errors, use std::any_of
Wael-MA Aug 13, 2026
5d8ae0b
Revert Wael-MA comments, switch to standard loops, and fix cctype casts
Wael-MA Aug 15, 2026
809b6d2
style: apply clang-format
Wael-MA Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/cmake_generator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1246,7 +1246,9 @@ void generate_cmake(const char *path, const parser::Project *parent_project) {
auto has_include = [](const parser::ConditionVector &includes) {
for (const auto &itr : includes) {
for (const auto &jtr : itr.second) {
return true;
if (!jtr.empty()) {
return true;
}
}
}
return false;
Expand Down Expand Up @@ -1935,7 +1937,7 @@ void generate_cmake(const char *path, const parser::Project *parent_project) {
auto generated_cmake = ss.str();

// Make sure the file ends in a single newline
while (!generated_cmake.empty() && std::isspace(generated_cmake.back())) {
while (!generated_cmake.empty() && std::isspace((unsigned char)generated_cmake.back())) {
generated_cmake.pop_back();
}
generated_cmake += '\n';
Expand Down
Loading