Fix preflight build with go-buildkite v5.13 - #974
Merged
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a05f9f-d477-70ab-95e8-cf80839291ba Co-authored-by: Ash McKenzie <ash.mckenzie@buildkite.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
![buildsworth-bk-app[bot]](https://avatars.githubusercontent.com/in/3010600?s=60&v=4){kind=small}
1 task
Contributor
Author
|
Thanks @nprizal for the review 🙇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The go-buildkite v5.13 upgrade removes the
BuildTestexecution-detail types, causing the preflight package to stop compiling. The only remaining users belonged to the in-progress test-failure event path, which has not been emitted since preflight switched to its final test summary.Changes
Remove the unreachable test-failure event rendering path, its obsolete API mocks, and its tests. The active final preflight test summary remains unchanged.
Testing
go test ./...)mise run format)mise run lintmise run vulncheckDisclosures / Credits
Amp diagnosed and implemented the fix, ran the verification checks, and used Amp's Oracle to review the complete change set.
Related: #973