Repository navigation
fix: gating-safe waves for every cluster group (review PR for #165, part 1) - #4
Merged
Merged
Conversation
main.gitops.applicationHealthCheckEnabled is set globally in values-global.yaml, so app-of-apps wave gating is now ON for every cluster group — but the two escape hatches that make a gated first sync work existed only in values-baremetal.yaml: - the wave -1 ClusterRoleBinding bridge (patterns-operator#887): ArgoCD applies wave-0 resources by kind, so the imperative ServiceAccounts are attempted before the chart's own cluster-admin binding; ungated installs self-heal on the next auto-sync, gated ones park on wave-0 health and deadlock. - the wave 15 acm application: the ACM chart renders the MultiClusterHub whose CRD is registered by the ACM operator — a wave-10 subscription. At wave 0 the acm app fails ArgoCD discovery on the not-yet-served operator.open-cluster-management.io/v1 and gates wave 10 behind itself: a hard deadlock. Give every cluster group the same shape as the live-validated values-baremetal.yaml layout (bridge at -1, vault/secrets/kyverno at 0, wait-for-vault-unsealed hook at 5, operator subscriptions at 10, acm at 15, trustee/policies at 20, workloads at 30): - values-baremetal-hub.yaml: bridge; acm -> wave 15; the acm.mce_operator.source tpl-conditional (mirrored catalog in airgap, redhat-operators otherwise); stale commented-out override block removed. - values-azure.yaml, values-trusted-hub.yaml: bridge + wave-5 wait-for-vault-unsealed hook (both run vault + ESO in-cluster) + full wave layout + the mce conditional. - values-azure-spoke.yaml: bridge + wave layout (no vault, no ACM). - values-baremetal-spoke.yaml: bridge; the airgap overlay becomes conditional like every other baremetal file — a CONNECTED spoke was previously pointed at cs-redhat-operator-index-v4-22, a mirrored catalog that does not exist outside airgap, leaving its sourceless subscriptions unresolvable. Connected renders verified unchanged apart from the additions above: full helm render of all six cluster groups diffed against a golden baseline captured at 7efafc8 (clustergroup chart 0.9.58). The spoke's connected render moves from 6 cs-* catalog references to 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR is
Fork-internal review PR for the work closing out validatedpatterns#165. Base is the validatedpatterns#165 branch
feat/t1-airgap-hardening(at7efafc8), so the diff below is exactly this round's work, not the 684-line validatedpatterns#165 delta. It folds back into validatedpatterns#165 after the review gate and lab validation pass.Design rule: the committed tree must be a working connected install with zero operator edits. Every disconnected delta stays an overlay scalar or a documented deploy-time value. The one permitted base-file exception is the
acm.mce_operator.sourcetpl-conditional (Helm replaces lists, so an overlay list would drop future base entries).Why
main.gitops.applicationHealthCheckEnabled: "true"is global, so sync-wave gating is ON for every cluster group — but the escape hatches that make a gated first sync work (wave −1 RBAC bridge, wave-15acm, wave-5 vault hook) existed only invalues-baremetal.yaml.values-baremetal-hub.yamldeadlocked deterministically; every other group was exposed to the wave-0 imperative-SA race. Separately, a connected baremetal-spoke was being pointed at a mirrored catalog that only exists in airgap.Status
7efafc8)Per-file connected-mode impact (S1)
values-baremetal.yamlvalues-baremetal-hub.yamlacm→15 · mce conditionalredhat-operators); stale comment block removedvalues-azure.yamlvalues-azure-spoke.yamlvalues-trusted-hub.yamlvalues-baremetal-spoke.yamlcs-*refs → 0)Verification so far:
helm templateof all six cluster groups with clustergroup 0.9.58, diffed against goldens captured at7efafc8— only the additions above; no unexpected removals; spokecs-*count 6 → 0.Accepted risk (stated up front)
The azure / azure-spoke / trusted-hub layouts are not live-validated this round (Azure testing deliberately out of scope). Acceptance rests on: 1:1 copy of the twice-validated baremetal layout, render-gate ordering assertions for all groups, the bridge/hook mechanism being proven live in V1 on baremetal, and per-file rollback.