perf(prune): keep an earlier row out of a later row's root - #1112
Merged
Merged
Conversation
`drop_regrowable` walked each `[[prune.regrowable]]` row across the whole target tree, so `incremental`, declared first, matched the `incremental` directories inside `perf*` and `semver*` — roots the consumer declares last because they are dearest to regrow. The lap-close escalation fired on most laps, and each time it stripped the perf arm's incremental state. Measured in a copy of `target/perf/arms`: the head arm's rebuild after a one-line edit costs 13 CPU-s with that state and 380-423 without, and 380 is what `perf-gate` paid on the last two ledgers. `directories_named_outside` does not descend into a directory a later row names. The later root goes whole on its own turn, or stays. `prune::tests::an_earlier_row_never_reaches_inside_a_later_rows_root` pins both halves; `later-root-unshielded` is killed by hand. Refs: CLOUD-2104
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 29 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
wenzowski
marked this pull request as ready for review
October 3, 2026 22:31
Contributor
Author
|
/fast-forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes CLOUD-2104
The lap-close prune escalation walked each
[[prune.regrowable]]row across the whole target tree. Theincrementalrow is declared first, so it also matched theincrementaldirectories insideperf*andsemver*. The consumer declares those roots last because they are the most expensive to regrow. Most laps escalate, and each time the escalation stripped the perf arm's incremental state.Measured in a copy of
target/perf/arms: after a one-line edit, the head arm rebuilds in 13 CPU-s with that state and in 380–423 CPU-s without it. 380 CPU-s is whatperf-gatepaid on the last two ledgers.directories_named_outsidedoes not descend into a directory that a later row names. The later root is taken whole on its own turn, or not at all.prune::tests::an_earlier_row_never_reaches_inside_a_later_rows_root; mutantlater-root-unshielded, killed by hand. Itssedscript was dry-run to confirm it matches exactly one line.target_pruneintegration cases pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01SFeJfGnT67NjjLWQJ1SgXB
Generated by Claude Code