Skip to content

Fix current-nightly CI#1629

Open
zRedShift wants to merge 1 commit into
bytecodealliance:mainfrom
zRedShift:ci-msrv163-current-nightly
Open

Fix current-nightly CI#1629
zRedShift wants to merge 1 commit into
bytecodealliance:mainfrom
zRedShift:ci-msrv163-current-nightly

Conversation

@zRedShift

@zRedShift zRedShift commented May 30, 2026

Copy link
Copy Markdown

Fixes the current nightly CI failures after rustc_attrs/feature(ip) behavior changed.

This is rebased on current main after #1594, so the previous Rust 1.63/libc pin work is gone.

Changes:

  • Probe rustc_attrs before enabling it.
  • Probe feature(ip) only when it is warning-clean.
  • Stop forcing --cfg=rustc_attrs in the std test-user job.
  • Patch crates.io rustix to the checkout in the all-apis/nested stdio test path.

Fixes #1620.

CI: https://github.com/bytecodealliance/rustix/actions/runs/28769170056

@xtqqczze

Copy link
Copy Markdown
Contributor

#1594 was merged, but CI is still broken due to #1620

@xtqqczze

xtqqczze commented Jul 5, 2026

Copy link
Copy Markdown
Contributor

@zRedShift could you remove the libc pin, now that MSRV is raised to 1.65

@zRedShift zRedShift force-pushed the ci-msrv163-current-nightly branch from 99a7104 to 9c6353a Compare July 6, 2026 05:07
@zRedShift zRedShift changed the title Keep CI working with Rust 1.63 and current nightly Fix current-nightly CI Jul 6, 2026
@zRedShift

Copy link
Copy Markdown
Author

@zRedShift could you remove the libc pin, now that MSRV is raised to 1.65

rebased on current main, removed the libc pin, and kept this focused on the current-nightly CI fixes for #1620.

@xtqqczze

xtqqczze commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

@sunfishcode PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error: attributes starting with rustc are reserved for use by the rustc compiler

2 participants