Skip to content

chore: bump cadence-client from 3.7.2 to 3.12.7 - #295

Merged
vladimir-gavrilenko merged 1 commit into
cadence-workflow:masterfrom
vladimir-gavrilenko:chore/bump-cadence-client-3.12.7
Oct 15, 2026
Merged

vladimir-gavrilenko merged 1 commit into
cadence-workflow:masterfrom
vladimir-gavrilenko:chore/bump-cadence-client-3.12.7

Conversation

@vladimir-gavrilenko

Copy link
Copy Markdown
Contributor

Which sample(s) or area?
build, common

What changed?
Bumped cadence-client from 3.7.2 to 3.12.7 in build.gradle. Updated WorkflowExecutionHistoryPrinter to call getHistory(...) and pass the result to prettyPrintHistory(Iterator, boolean), because the prettyPrintHistory(IWorkflowService, String, WorkflowExecution, boolean) overload was removed after 3.12.0.

Why?
Keep the samples on a current client release. The removed overload only called getHistory(...) and then prettyPrintHistory(Iterator, boolean), so the replacement is the same two calls made explicitly.

How did you test it?
Build, on JDK 11 (the version CI uses):
./gradlew clean build

Manual test against a local Cadence server (SQLite):

  1. Start the server, from a cadence checkout: make bins install-schema-sqlite && ./cadence-server --zone sqlite start
  2. Register the domain, once the server is up: ./gradlew -q execute -PmainClass=com.uber.cadence.samples.common.RegisterDomain
  3. Run a sample: ./gradlew -q execute -PmainClass=com.uber.cadence.samples.hello.HelloActivity

Potential risks
Low. WorkflowExecutionHistoryPrinter output now includes whatever fields the 3.12.7` history model has, so it differs from 3.7.2 in field order and in a few extra fields.

Release notes
N/A

Documentation Changes
N/A

**Which sample(s) or area?**
build, common

**What changed?**
Bumped `cadence-client` from 3.7.2 to 3.12.7 in `build.gradle`. Updated
`WorkflowExecutionHistoryPrinter` to call `getHistory(...)` and pass the result to
`prettyPrintHistory(Iterator, boolean)`, because the
`prettyPrintHistory(IWorkflowService, String, WorkflowExecution, boolean)` overload
was removed after 3.12.0.

**Why?**
Keep the samples on a current client release. The removed overload only called
`getHistory(...)` and then `prettyPrintHistory(Iterator, boolean)`, so the replacement
is the same two calls made explicitly.

**How did you test it?**
Build, on JDK 11 (the version CI uses):
`./gradlew clean build`

Manual test against a local Cadence server (SQLite):

1. Start the server, from a cadence checkout:
`make bins install-schema-sqlite && ./cadence-server --zone sqlite start`
2. Register the domain, once the server is up:
`./gradlew -q execute -PmainClass=com.uber.cadence.samples.common.RegisterDomain`
3. Run a sample:
`./gradlew -q execute -PmainClass=com.uber.cadence.samples.hello.HelloActivity`

Ran this way (same command, different class): HelloActivity, HelloActivityRetry,
HelloAsync, HelloAsyncLambda, HelloAsyncActivityCompletion, HelloChild, HelloException,
HelloQuery, HelloConsistentQuery, HelloSignal, HelloSideEffect, HelloLocalActivity,
HelloSaga, HelloCancellation, HelloSearchAttributes and HelloDataConverter. All printed
the expected output. HelloSignalAndResponse and HelloCancelChild did not exit on their
own; they behave the same on 3.7.2. WorkflowExecutionHistoryPrinter
(`--args="<workflowId> <runId>"`) printed the history of a real workflow. Not run:
HelloCron, HelloPeriodic, HelloMetric, HelloWorkerSetup, and the samples outside the
hello package.

**Potential risks**
Dependency upgrade (3.7.2 -> 3.12.7); transitive dependency versions changed.
WorkflowExecutionHistoryPrinter output now includes whatever fields the 3.12.7 history
model has, so it differs from 3.7.2 in field order and in a few extra fields.

**Release notes**
N/A

**Documentation Changes**
N/A

Signed-off-by: Vladimir Gavrilenko <vladi.a.gavri@gmail.com>
@gitar-bot

gitar-bot Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved

🟡 Medium risk · Upgrading cadence-client from 3.7.2 to 3.12.7 changes client behavior and could affect sample execution or workflow-history retrieval.

Bumps cadence-client from 3.7.2 to 3.12.7 in build.gradle and updates WorkflowExecutionHistoryPrinter to call getHistory(...) and pass the result to prettyPrintHistory(Iterator, boolean), replacing the removed overload. No issues found.

Verification Rules 1/1 met PRs 1 inspected

Functional validation No results

Rules 1 passed

✅ PR Description Quality Standards

Broader impact PRs 1 inspected
Cross-PR 1 PR inspected 0 open impacts

PR #1107: feat: Add ApplicationException Inspected

For more verification details, comment gitar display:verbose.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

@dkrotx dkrotx left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes total sense

@vladimir-gavrilenko
vladimir-gavrilenko merged commit 689f3db into cadence-workflow:master Oct 15, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants