Repository navigation
chore: bump cadence-client from 3.7.2 to 3.12.7 - #295
vladimir-gavrilenko merged 1 commit into
Conversation
**Which sample(s) or area?** build, common **What changed?** Bumped `cadence-client` from 3.7.2 to 3.12.7 in `build.gradle`. Updated `WorkflowExecutionHistoryPrinter` to call `getHistory(...)` and pass the result to `prettyPrintHistory(Iterator, boolean)`, because the `prettyPrintHistory(IWorkflowService, String, WorkflowExecution, boolean)` overload was removed after 3.12.0. **Why?** Keep the samples on a current client release. The removed overload only called `getHistory(...)` and then `prettyPrintHistory(Iterator, boolean)`, so the replacement is the same two calls made explicitly. **How did you test it?** Build, on JDK 11 (the version CI uses): `./gradlew clean build` Manual test against a local Cadence server (SQLite): 1. Start the server, from a cadence checkout: `make bins install-schema-sqlite && ./cadence-server --zone sqlite start` 2. Register the domain, once the server is up: `./gradlew -q execute -PmainClass=com.uber.cadence.samples.common.RegisterDomain` 3. Run a sample: `./gradlew -q execute -PmainClass=com.uber.cadence.samples.hello.HelloActivity` Ran this way (same command, different class): HelloActivity, HelloActivityRetry, HelloAsync, HelloAsyncLambda, HelloAsyncActivityCompletion, HelloChild, HelloException, HelloQuery, HelloConsistentQuery, HelloSignal, HelloSideEffect, HelloLocalActivity, HelloSaga, HelloCancellation, HelloSearchAttributes and HelloDataConverter. All printed the expected output. HelloSignalAndResponse and HelloCancelChild did not exit on their own; they behave the same on 3.7.2. WorkflowExecutionHistoryPrinter (`--args="<workflowId> <runId>"`) printed the history of a real workflow. Not run: HelloCron, HelloPeriodic, HelloMetric, HelloWorkerSetup, and the samples outside the hello package. **Potential risks** Dependency upgrade (3.7.2 -> 3.12.7); transitive dependency versions changed. WorkflowExecutionHistoryPrinter output now includes whatever fields the 3.12.7 history model has, so it differs from 3.7.2 in field order and in a few extra fields. **Release notes** N/A **Documentation Changes** N/A Signed-off-by: Vladimir Gavrilenko <vladi.a.gavri@gmail.com>
Code Review ✅ Approved🟡 Medium risk · Upgrading cadence-client from 3.7.2 to 3.12.7 changes client behavior and could affect sample execution or workflow-history retrieval. Bumps Verification Rules 1/1 met PRs 1 inspectedFunctional validation No results Rules 1 passed
Broader impact PRs 1 inspectedCross-PR 1 PR inspected 0 open impacts
For more verification details, comment OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
Which sample(s) or area?
build, common
What changed?
Bumped
cadence-clientfrom 3.7.2 to 3.12.7 inbuild.gradle. UpdatedWorkflowExecutionHistoryPrinterto callgetHistory(...)and pass the result toprettyPrintHistory(Iterator, boolean), because theprettyPrintHistory(IWorkflowService, String, WorkflowExecution, boolean)overload was removed after 3.12.0.Why?
Keep the samples on a current client release. The removed overload only called
getHistory(...)and thenprettyPrintHistory(Iterator, boolean), so the replacement is the same two calls made explicitly.How did you test it?
Build, on JDK 11 (the version CI uses):
./gradlew clean buildManual test against a local Cadence server (SQLite):
make bins install-schema-sqlite && ./cadence-server --zone sqlite start./gradlew -q execute -PmainClass=com.uber.cadence.samples.common.RegisterDomain./gradlew -q execute -PmainClass=com.uber.cadence.samples.hello.HelloActivityPotential risks
Low.
WorkflowExecutionHistoryPrinteroutput now includes whatever fields the 3.12.7` history model has, so it differs from 3.7.2 in field order and in a few extra fields.Release notes
N/A
Documentation Changes
N/A