Run repository-creating tests in temp dirs - #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several tests create CADET-RDM repositories through relative paths such as
test_repo*andnon_rdm_repo. When those tests run from the repository root, the generated repositories are left behind as untracked files after the test run.This adds module-local autouse fixtures that change the working directory to pytest's per-test
tmp_pathfor the affected test modules. The tests can keep their existing relative-path setup, but the generated repositories now land in pytest-managed temporary directories instead of polluting the project checkout.Tested with:
pytest tests/test_git_adapter.py tests/test_cli.py tests/test_batch_runner.py -m 'not server_api and not container'