Repository navigation
chore: remove unnecessary dependencies from example app - #1175
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The sliding indicators do not correctly track pages when the example app runs in RTL mode.
1 open finding
What changed in this PR
Removes unused example-app dependencies and replaces SVG-based pagination indicators with native React Native views.
Changes:
- Adds custom animated pagination-dot components.
- Removes gesture-handler, SVG, and pagination-dot dependencies.
- Updates native lockfiles and provider wrappers.
| File | Description |
|---|---|
example/src/PaginationDotsExample.tsx |
Uses custom pagination indicators. |
example/src/component/PaginationDots.tsx |
Implements four animated indicators. |
example/src/component/NavigationPanel/LogsPanel.tsx |
Uses React Native’s FlatList. |
example/src/App.tsx |
Removes the gesture-handler root wrapper. |
example/package.json |
Removes unused dependencies. |
example/ios/Podfile |
Removes obsolete RNSVG workaround. |
example/ios/Podfile.lock |
Removes deleted native pods. |
bun.lock |
Updates resolved dependencies. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| const BORDER_SIZE = 20; | ||
|
|
||
| export function SlidingBorder({ progress, count, testID }: Props) { | ||
| const translateX = Animated.multiply(progress, BORDER_SIZE); |
🟢 e2e: 14 passedAll 14 tests in 10 files
e2e 0.18.0 · 4m 18s · android · run artifacts |
🟢 e2e: 13 passedAll 13 tests in 11 files
e2e 0.18.0 · 5m 29s · ios · run artifacts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes unused dependencies and rewrites simple dots component to custom one to avoid using
RNSVG