Clear contexts and blockedBy on empty-array updates - #2221
Open
tgrosinger wants to merge 1 commit into
Open
Conversation
The frontmatter deletion pass in removeUnsetMappedFields only removed
the contexts and blockedBy keys when the update held a literal
undefined, which JSON cannot express. HTTP clients sending
PUT {"contexts": []} or {"blockedBy": []} therefore got a 200 with
the previous value silently left in place. Use the same hasOwnProperty
plus empty-array deletion pattern that projects and reminders already
use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The frontmatter deletion pass in removeUnsetMappedFields only removed the contexts and blockedBy keys when the update held a literal undefined, which JSON cannot express. HTTP clients sending
PUT {"contexts": []}orPUT {"blockedBy": []}therefore got a 200 with the previous value silently left in place. Use the samehasOwnPropertyplus empty-array deletion pattern that projects and reminders already use.