[antoniacobaeus]

No description provided.

[xstecuc]

Why not simply making the tower-commons public and generate GitHub releases instead of pushing it to a public S3 repo?

[antoniacobaeus]

That would work as well! The publish job for S3 was fairly simple and the added benefit is that staging logic is completely hidden from the end user. The other benefit is that things that are being worked on, PRs and so on, are not shown until ready. The downside is of course that we need to run the publish when we want changes, but it is very quick :)

For development we would instead point it to either the local builds or the github releases, since we have access. Once we also publish tower premium to S3, the flow will be similar but with authentication.

If we prefer to have commons public we can do that

[antoniacobaeus]

Something I haven't looked into is how the terraform registry handles it and if we want to have tower-commons there, does it need a public repo?

[xstecuc]

I don't think we need to have tower-commons in the TF registry. The common module is publicly accessible anyway but we just don't need to expose it as is because it has no value otherwise. The registry is just to ease the search and standardise the use of different providers and modules.

[xstecuc]

Another comment outside of these changes. Add the required

  cvm_platform = {
    cpu = "snp"
  }

in the examples/ files.

Otherwise, it works as expected. Good job!

[xstecuc]

LGTM