Repository navigation
cmd/microcloud: Issue each peer's join tokens just before its join - #1613
Open
jrtorsella wants to merge 1 commit into
Open
jrtorsella wants to merge 1 commit into
jrtorsella wants to merge 1 commit into
Conversation
This PR prevents an issue where every service join token was issued before the first join such that if there were many joins to do the tokens for the later joiners could expire before their joins had a chance to start (or finish). This changes the behavior to issue tokens prior to each join rather than all at once at the beginning. Fixes canonical#1565 Signed-off-by: Joseph Robert Torsella <joey.torsella@canonical.com>
There was a problem hiding this comment.
🟢 Approval recommended
The localized change preserves sequential joining and adds focused regression coverage, with no blocking issues identified.
0 open findings
What changed in this PR
This PR prevents join tokens from expiring while peers wait for earlier joins to finish.
Changes:
- Issues each peer’s service tokens immediately before its sequential join.
- Adds a regression test checking token timing and successful peer joins.
| File | Description |
|---|---|
cmd/microcloud/main_init.go |
Moves token issuance into the per-peer join sequence. |
cmd/microcloud/main_init_test.go |
Tests token issuance timing across multiple peers. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jrtorsella
marked this pull request as ready for review
October 16, 2026 14:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents an issue where every service join token was issued before the first join such that if there were many joins to do the tokens for the later joiners could expire before their joins had a chance to start (or finish). This changes the behavior to issue tokens prior to each join rather than all at once at the beginning.
Fixes #1565
https://warthogs.atlassian.net/browse/LXD-5259?atlOrigin=eyJpIjoiZTUyMzQ1NzU0NmM4NDIyNWE0NTg0MjE3NmU0ZDBmZTIiLCJwIjoiaiJ9
Checklist