You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bring in Ulwazi as the default theme for Sphinx Stack 3.0 and higher. Marking as breaking because this introduces new potential failure points for documentation projects.
Removes custom templates that are now incompatible
Remove unused html_title declaration
Append " documentation" to project, as it's no longer visible in the banner or above the global nav
Drops explicit notfound dependency, as it's now set up by Ulwazi
Adds myst-parser to extensions, as it's no longer set up by canonical-sphinx
Note for reviewers: You'll have to check out and build locally to validate the changes. I'm mainly looking for feedback on the default configuration of the banner (link text, destination URLs, and so on).
There is no Preview PR build here, which is weird. It would be helpful to test a few RTD-specific features, like Feedback links.
It's because the RTD project is sourced from the sphinx-stack-docs repo. I'll create a new RTD project for testing changes here when I have some downtime. For these changes, I'd ask that you validate what you can without it, and we can ensure everything works when I update the docs repo to 3.0 (hopefully later today if I can get this merged).
Yes, I'm working on it.
So far everything seems to be mostly OK. There is a MyST extensions fix that I'm implementing into Ulwazi.
Other than that, a few minor things, including some stale comments in conf.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring in Ulwazi as the default theme for Sphinx Stack 3.0 and higher. Marking as breaking because this introduces new potential failure points for documentation projects.
html_titledeclarationproject, as it's no longer visible in the banner or above the global navmyst-parsertoextensions, as it's no longer set up by canonical-sphinxNote for reviewers: You'll have to check out and build locally to validate the changes. I'm mainly looking for feedback on the default configuration of the banner (link text, destination URLs, and so on).
CHANGELOG.md?