Use new release workflow of cap-java/.github and update shas - #137
Use new release workflow of cap-java/.github and update shas#137lisajulia wants to merge 1 commit into
Conversation
![hyperspace-pr-bot[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
There was a problem hiding this comment.
The PR is a clean SHA-bump across all shared workflow/action references, replacing 296573b55e906f5c77a1855bcfe4285cbbc5cac4 with b5eb1ad6341e9fd1d681c42f3b36c4b750a7dac2, plus a welcome simplification of release.yml by delegating to the centralized reusable workflow. The only minor issue is the missing # main comment on the new release.yml call-site, which is inconsistent with every other updated reference in this PR.
PR Bot Information
Version: 1.29.45
- File Content Strategy: Full file content
- LLM:
anthropic--claude-4.6-sonnet - Event Trigger:
pull_request.opened - Correlation ID:
871988e0-a0ad-11f1-91da-84825433ed8d
| maven-version: ${{ env.MAVEN_VERSION }} | ||
| maven-profiles: "deploy-release,'!with-integration-tests'" | ||
| release: | ||
| uses: cap-java/.github/.github/workflows/release.yml@b5eb1ad6341e9fd1d681c42f3b36c4b750a7dac2 |
There was a problem hiding this comment.
Best Practices: Missing # main comment on the pinned SHA reference.
Every other workflow file updated in this PR uses the convention @<sha> # main to document which branch the SHA was taken from, making it easy to verify and update the pin later. This line is the only one missing that annotation, reducing traceability consistency across the workflow files.
| uses: cap-java/.github/.github/workflows/release.yml@b5eb1ad6341e9fd1d681c42f3b36c4b750a7dac2 | |
| uses: cap-java/.github/.github/workflows/release.yml@b5eb1ad6341e9fd1d681c42f3b36c4b750a7dac2 # main |
Double-check suggestion before committing. Edit this comment for amendments.
Please provide feedback on the review comment by checking the appropriate box:
- 🌟 Awesome comment, a human might have missed that.
- ✅ Helpful comment
- 🤷 Neutral
- ❌ This comment is not helpful
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| uses: cap-java/.github/.github/workflows/release.yml@b5eb1ad6341e9fd1d681c42f3b36c4b750a7dac2 | ||
| with: | ||
| java-version: '17' | ||
| blackduck-project-name: com.sap.cds.cds-ai | ||
| blackduck-included-modules: cds-feature-ai-core,cds-feature-recommendations,cds-starter-ai | ||
| build-maven-args: "-P '!with-integration-tests'" | ||
| deploy-maven-profiles: "deploy-release,'!with-integration-tests'" | ||
| secrets: inherit |
2 participants
Update
cap-java/.githubAction SHAs and Migrate to Shared Release WorkflowChore
🔧 Updated all
cap-java/.githubaction and workflow references from the old SHA (296573b) to the new SHA (b5eb1ad), and replaced the inline release workflow with a call to the shared reusable release workflow fromcap-java/.github.Changes
.github/actions/cf-bind/action.yml: Updatedcf-loginaction SHA tob5eb1ad..github/workflows/issue.yml: Updatedissue.ymlworkflow SHA tob5eb1ad..github/workflows/main.yml: Updatedscan-with-blackduckaction SHA tob5eb1ad..github/workflows/pipeline.yml: Updatedscan-with-codeqlaction SHA tob5eb1ad..github/workflows/prevent-issue-labeling.yml: Updatedprevent-issue-labeling.ymlworkflow SHA tob5eb1ad..github/workflows/stale.yml: Updatedstale.ymlworkflow SHA tob5eb1ad..github/workflows/release.yml: Removed the inline release job definitions (approval gate, version verification, BlackDuck scan, build, and deploy steps) and replaced them with a single call to the sharedcap-java/.github/.github/workflows/release.ymlreusable workflow, passing relevant inputs (java-version,blackduck-project-name,blackduck-included-modules,build-maven-args,deploy-maven-profiles) and inheriting secrets. Also removed the top-levelenvblock forJAVA_VERSIONandMAVEN_VERSIONas these are now passed as workflow inputs.PR Bot Information
Version:
1.29.45pull_request.openedanthropic--claude-4.6-sonnet871988e0-a0ad-11f1-91da-84825433ed8d