Fixing some latent type errors#5584
Open
ef4 wants to merge 1 commit into
Open
Conversation
While working on removing the standalone declarations build in boxel-ui, we discovered that there are many pre-existing type errors that were being hidden behind skipLibCheck. Once you start type-checking boxel-ui directly against source, it's no longer hidden behind skipLibCheck and these errors surface. This is just a partial set of them, more need to be fixed before we can actually stop pre-building the boxel-ui declarations.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on removing the standalone declarations build in boxel-ui, @backspace and I discovered that there are many pre-existing type errors that were being hidden behind skipLibCheck. Once you start type-checking boxel-ui directly against source, it's no longer hidden behind skipLibCheck and these errors surface.
This is just a partial set of them, more need to be fixed before we can actually stop pre-building the boxel-ui declarations.