Default new realms to a Workspace index card#5587
Draft
lukemelia wants to merge 1 commit into
Draft
Conversation
Contributor
Host Test Results 1 files ±0 1 suites ±0 2h 37m 44s ⏱️ +20s Results for commit 4b29bc8. ± Comparison against earlier commit b07a65f. Realm Server Test Results 1 files ±0 1 suites ±0 12m 1s ⏱️ +9s Results for commit 4b29bc8. ± Comparison against earlier commit b07a65f. |
create-realm seeds every new realm's index.json; point it at Workspace instead of CardsGrid so newly created realms open to the Workspace experience. The publish handler and prerender fast-path already recognize both cards (so a new realm still gets the prerendered default-index treatment on publish), and CardsGrid stays available for existing realms. Update the publish/unpublish tests: the default-index case now exercises Workspace, and the explicit case covers the legacy CardsGrid path so both recognized defaults stay tested. Fix software-factory comments that described the old CardsGrid default (the factory overwrites the index regardless). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
lukemelia
force-pushed
the
cs-12294-workspace-default-index
branch
from
July 23, 2026 03:05
b07a65f to
4b29bc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
create-realm.tsseeds every new realm'sindex.json. Point it atWorkspaceinstead ofCardsGrid, so a newly created realm opens to the Workspace experience. This is the "replace CardsGrid" keystone — the card, the recognition, and the migration are only meaningful once the default flips.CardsGrid stays available for existing/bespoke realms; only the default for freshly created realms changes.
Depends on
Blast radius (audited)
The realm-server test helper
createRealmseeds its ownfileSystem, so it does not go through this handler — most realm-server tests are unaffected. Of the tests that hit the real/_create-realmendpoint:index-responsesandrealm-lifecycleseed their ownindex.json→ unaffected.realm-routing's deadlock guard uses a mock fixture, not a real create+prerender → unaffected (comment now slightly historical).publish-unpublishcreates its source realm via the endpoint and did rely on the default being CardsGrid → updated here: the default-index case now exercises Workspace, and the explicit case is repurposed to cover the legacy CardsGrid path, so both recognized defaults stay tested; the bespoke-index negative case is unchanged.Also fixed software-factory comments that described the old CardsGrid default (the factory overwrites the index regardless, so it's behavior-neutral).
Test plan
realm-server
ember-tsc, eslint, prettier clean. Not run locally — the realm-server publish/create suites need test-pg + their own prerender, which isn't wired up in this session; they run in CI. Given the default flip is behaviorally significant, CI's full realm-server + matrix suites (which create realms via/_create-realm) are the real confirmation. The publish test changes mirror the existing passing tests' structure.🤖 Generated with Claude Code