Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A shared
SandboxPoolcan return a sandbox owned by another provider instance when both requests use the same labels. For example, acquire and release with account A, then acquire with account B using{"project": "demo"}: B receives A's sandbox ID and its provider never creates a sandbox. This also crosses credentials when the two instances have the same provider name.Require provider instance ownership during label-based reuse. Matching resources from the same instance still reuse correctly, and the pool's public label lookup remains unchanged.
Validation: the regression fails on main with
first-account-1returned to the second account; it passes with the fix. All 209 offline tests pass (1 credential-dependent test skipped, 30 integration tests deselected), and full Ruff/Black checks pass. Mypy reports the same 57 diagnostics in 11 files on the unchanged base and this branch; CI already treats that check as advisory. No cloud sandbox was created.AI assistance: implemented and tested with Codex.