Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RetryHandler.execute()accepts callable objects, but a failure in afunctools.partialor an instance with__call__raisesAttributeErrorfrom the retry log'sfunc.__name__lookup. That prevents a transient failure from being retried and replaces the original exception when retries are disabled.Use the callable's name when available, otherwise its type name, for retry diagnostics. Retry decisions and operation arguments are unchanged.
Validation: all three new regressions fail on main; they now prove retry success for partials and callable instances and preservation of the original terminal error. All 211 offline tests pass (1 credential-dependent skip, 30 integration tests deselected), plus full Ruff and Black. Mypy reports the same 57 base diagnostics and is advisory in repository CI. No provider service was contacted.
AI assistance: implemented and tested with Codex.