Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pool indexes labels as
key:valuestrings, so{"scope:project": "a"}and{"scope": "project:a"}become the same key.find_by_labels()returns the wrong sandbox, andacquire()can reuse it for a different label set.Use
(key, value)pairs as the internal index keys for creation, lookup and removal. Public label dictionaries and subset matching retain their existing interface.Validation: the new regression fails on main because the distinct labels match the first sandbox. It now proves separate allocation and correct lookups for both label sets. All 209 offline tests pass (1 credential-dependent skip, 30 integration tests deselected), and full Ruff/Black pass. Mypy retains the unchanged base's 57 advisory diagnostics. No cloud sandbox was created.
AI assistance: implemented and tested with Codex.