Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A predicate supplied through
RetryConfig.should_retrycannot stop retries: returningFalsefalls through to the defaultTruedecision. An operation that explicitly should not be repeated therefore runs three times withmax_retries=2. The runtime-assigned predicate already honors its result.Honor both boolean results from the configured predicate. Preserve the existing error fallback when the predicate itself raises. Correct the existing conditional-predicate test, whose comment says odd attempts must stop retrying but whose assertion previously expected all four calls to succeed.
Validation: the new regression fails on main with three calls and passes with one. All 209 offline tests pass (1 credential-dependent skip, 30 integration tests deselected), and full Ruff/Black pass. Mypy retains the unchanged base's 57 advisory diagnostics. No provider service was contacted.
AI assistance: implemented and tested with Codex.