Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
sandbox testcommand currently prints a provider asWorkingand exits successfully even when its probe command fails or returns unexpected output. Failed sandbox cleanup is also printed as successful.Track probe and cleanup failures, report them in the summary, and return a nonzero status while continuing to test the remaining providers. Successful probes retain exit status zero.
Validation: the regression tests fail on current main (three failures, one passing control) and all four pass after this change. The 31 CLI tests and 212 offline tests pass; one live-credential test is skipped and 30 integration tests are deselected. Ruff and Black pass. Mypy remains advisory in the repository workflow and reports the same existing 57 diagnostics. No cloud calls were made.