Bump sonar-cryptography-plugin to 1.6.1 - #51
Merged
Conversation
Update sonar.crypto.plugin.version from 1.5.1 to 1.6.1 and re-derive the affected test expectations from the actual CBOM output. 1.6.1 normalizes algorithm component names to hyphenated forms (SHA256 -> SHA-256, HMAC-SHA256 -> HMAC-SHA-256, AES128-CBC-PKCS7 -> AES-128-CBC-PKCS7, PBKDF2 -> PBKDF2-SHA-256). The Go fixture also yields one additional component (27 -> 28); finding counts and line numbers are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates
sonar.crypto.plugin.versionfrom1.5.1to1.6.1and re-derives the affected test expectations from the actual CBOM output under the new plugin version.Test expectation changes
1.6.1 normalizes algorithm component names to hyphenated forms:
SHA256SHA-256HMAC-SHA256HMAC-SHA-256AES128-CBC-PKCS7AES-128-CBC-PKCS7PBKDF2PBKDF2-SHA-256The Go fixture also yields one additional component (27 → 28). Finding counts (69 for Go, 5 for Python) and all line numbers are unchanged. Java tests needed no changes.
Expected values were re-derived by dumping the actual components/occurrences produced by 1.6.1, not guessed.
The component-name normalization is not internal to the tests — any downstream code that matches on CBOM component names (e.g.
SHA256) will no longer match. Worth calling out to CBOMkit service / cbomkit-action.Test plan
mvn clean package— 18/18 tests passNote: the build fails locally on JDK 25 because spotless' google-java-format hits
NoSuchMethodErroronLog$DeferredDiagnosticHandler— unrelated to this change. Built with Temurin 21, which is what CI uses.