Skip to content

fix: show the releases as a top pane and let the release page shrink with the dialog #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cechout merged 1 commit into from
Oct 6, 2026
Merged

fix: show the releases as a top pane and let the release page shrink with the dialog #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions FluentMath/Views/ReleaseNotesDialog.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
<!-- (the size is applied in code, see ResizeToWindow) -->
<Grid x:Name="RootGrid">
<Grid.RowDefinitions>
<RowDefinition Height="Auto" />
<RowDefinition Height="Auto" />
<RowDefinition Height="*" />
</Grid.RowDefinitions>
Expand Down Expand Up @@ -76,7 +77,12 @@
</Button>
</Grid>

<!-- content: a NavigationView driving a Frame, for the native page transition -->
<!-- release list: a NavigationView driving the Frame below, for the native page transition -->
<!--
(the Frame is not its content: on top the pane asks for its items, the overflow button and a 48 wide
custom content column, and a narrower dialog arranges the whole control at that width and clips it,
the page with it)
-->
<NavigationView
x:Name="ReleaseNav"
Grid.Row="1"
Expand All @@ -85,9 +91,21 @@
IsPaneToggleButtonVisible="False"
IsSettingsVisible="False"
OpenPaneLength="80"
PaneDisplayMode="Left"
PaneDisplayMode="Top"
SelectionChanged="ReleaseNav_SelectionChanged">

<!-- (no custom content in the pane, so its column needs no width of its own) -->
<NavigationView.Resources>
<x:Double x:Key="TopNavigationViewPaneCustomContentMinWidth">0</x:Double>
</NavigationView.Resources>
</NavigationView>

<!-- release page, with the fill and the line the NavigationView would draw under a top pane -->
<Border
Grid.Row="2"
Background="{ThemeResource NavigationViewContentBackground}"
BorderBrush="{ThemeResource NavigationViewContentGridBorderBrush}"
BorderThickness="{ThemeResource TopNavigationViewContentGridBorderThickness}">
<Grid>
<!-- release page -->
<Frame x:Name="ReleaseFrame" />
Expand All @@ -114,6 +132,6 @@
TextWrapping="Wrap"
Visibility="Collapsed" />
</Grid>
</NavigationView>
</Border>
</Grid>
</ContentDialog>
4 changes: 2 additions & 2 deletions FluentMath/Views/ReleaseNotesDialog.xaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ public sealed partial class ReleaseNotesDialog : ContentDialog
// in px; the window can be far narrower than the dialog, so both sides are capped to a share of it
private const double DialogWidth = 550;
private const double MaxDialogHeight = 740;
private const double MinDialogHeight = 460;
private const double MinDialogHeight = 400;
private const double HeightFraction = 0.85; // of the window height
private const double MaxWindowShare = 0.95; // of the window width and height
private const double MaxWindowShare = 1.0; // of the window width and height


// === constructor ===
Expand Down
Loading