docs(partners): link provider address catalogs instead of hardcoding partner contract addresses - #2278
Merged
Merged
Conversation
…partner contract addresses Witnet and Band pages linked stale/rotating addresses; the Farcaster swap example used Ethereum's Uniswap V2 router, which has no code on Celo. Replace hardcoded partner addresses with links to the providers' canonical catalogs, placeholder-and-link for the router, and label example recipient addresses. Refs #2277 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
palango
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hole, and the fix
Partner contract addresses hardcoded in our pages rot invisibly — nothing watches on-chain activity. Verified via Blockscout on 2026-08-24: the Witnet price-feed proxy we list (
0x1111AbA2…) has been quiet on mainnet since 2026-01-23 while anotherWitnetProxy(0x3210564c…) has posted daily since and is active today; of the two Witnet randomness contracts, the newerWitRandomnessV3's last recorded tx (2026-02-27) predatesWitnetRandomnessV2's (2026-04-22) — which one is canonical is the provider's call, not ours. Both benchmarked docs sets already avoid this class of bug: Optimism's oracles page links each provider's own address catalog; Base lists no partner addresses at all. Our Chainlink / RedStone / Supra / DIA / Quex pages already carry zero addresses — Witnet and Band were the outliers.Changes (3 of the 6 pages inventoried in #2277 needed edits):
tooling/oracles/wit-oracle.mdx— both address blocks (price-feed proxy incl. the hardcoded address in the code sample, and randomness) replaced with links to Witnet's canonical pages (Celo price feeds, randomness contract addresses, feeds.witnet.io/celo — all returned 200 today). The retired-Alfajores bullets went with them.tooling/oracles/band-protocol.mdx— the two inline literals dropped; the text already told readers to check Band's page for the current address, now it only does that.build-on-celo/build-with-farcaster.mdx— the swap example's router0x7a250d5630B4cF539739dF2C5dAcb4c659F2488Dis Ethereum's Uniswap V2 router;eth_getCodeon Celo mainnet returns 0 bytes, so the example as written could not work. Replaced with a placeholder + link to Uniswap contracts on Celo and aWarningthat the ABI must match a router actually deployed on Celo (v3/v4). The two Anvil test recipients are now labelled// example recipient — replace.Reviewed, deliberately unchanged (the other 3 pages from the inventory):
build-with-usat.mdx(USA₮ token0xD2ab…+ adapter0x0357…are Celo fee-allowlist entries; the adapter was verified in the on-chain FeeCurrencyDirectory in #2273's evidence),nightfall.mdx(CELO token-duality address, Sepolia USD₮ matchingfee-currencies.mdx:74, and a clearly-scoped example variable),ledger/to-celo-cli.mdx(0x…0001test recipient in a test command).The policy sentence itself ("partner addresses live with the provider; Celo-core tables stay; example addresses are labelled") is added to
AGENTS.mdas a commit on #2269, where that file is already under review.What this does NOT do / residual risk
legacy/).wit-oracle.mdxis currently orphaned from nav; task: Orphaned-pages audit — re-nav or delete the 22 pages on disk that are missing from navigation #2253 re-navs it after this lands (note already on the sheet/issue).Judgement calls
"0xYourSwapRouterAddress") over picking a router for the reader: choosing v3SwapRouter02would silently break with the v2 ABI in the same snippet. Reversible either way.Issues
Refs #2277 — closes the three-page fix and the three-page review; the AGENTS.md box closes when #2269 merges; the "#2253 waits" note is already posted.
Stacking / conflicts
Branched off
main, independent of my other open PRs (none touches these three files). The AGENTS.md policy commit rides on #2269.Verification evidence
All five provider-catalog URLs linked returned 200 today.
Remaining ops steps
Checklist
mainmint broken-linkspasses